Skip to content

Minor improvements in SOAP __doRequest dispatch #18687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2025
Merged

Minor improvements in SOAP __doRequest dispatch #18687

merged 2 commits into from
May 28, 2025
+12 −13

Conversation

nielsdos
Copy link
Member

See individual commits

nielsdos added 2 commits May 28, 2025 19:16
@nielsdos
Use function table directly in soap do_request
8e9c3fe 
The function will exist, avoid creating a temporary string and
lowercasing it.
@nielsdos
Avoid creating a zend_string twice in soap do_request
2cf4155
devnexen
devnexen approved these changes May 28, 2025
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mstm

@nielsdos nielsdos merged commit b05d50e into php:master May 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
Extension: soap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @devnexen